-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(infinite-scroll): properly updates scrollTop of ion-content #12599
Conversation
thanks @Khalid-Nowaf fixes #11745 fixes #11211
When `Tabs` are nested within each other, the highlight can get misaligned. This prevents that by ensuring the affected `.tab-highlight` is a direct child of the targeted `Tabs`.
…tabs * wip * wip * progress * wippy skippy * getting there * all tests passing except goBack * unit tests pass again boi * goBack tests pass * great success * the good stuff
restore getActiveNav api
… npm issues people are having
…ays not to do this
* chore(docs): add anchor links to documentation sub-sections * chore(docs): make entire section headings clickable as anchors
* wip * simple-nav, simple-tabs, simple-nav-then-tabs, simple-nested-navs all pass w00t w00t * updates * fix tests * update test
…segment had the exact same string
* feat(generators): update templates * feat(generators): add pipeName to templates
…t doesn't get lost
…stroying a nav controller while its transitioning
Also contains a fix for iOS scrolling motion conflict and setting scrollTop Fixes #11587
As a temporary solution, I just copy pasted import { InfiniteScroll as IonicInfiniteScroll } from 'ionic-angular'
@Directive({
selector: 'my-infinite-scroll',
providers: [
{ provide: IonicInfiniteScroll, useExisting: forwardRef(() => InfiniteScroll) }
]
})
export class InfiniteScroll { |
@brandyscarney Any ETA when this will be integrated to ionic? |
@stalniy I've tried to use your InfiniteScroll class in my project, but it didn't work for me. This is what I did:
On iOS the lazy loading stopped working completely without any error. Could you please provide the file you've added to your project? Maybe I did something wrong somewhere... Ionic 3.6.1 This is my code: |
@tobiasmuecksch here is the snippet https://gist.github.com/stalniy/bea9a080387ddaef65d6e04628f744cb Don't forget to import module with your custom infinite scroll |
@stalniy I 've tried your snippet and it works most of time. |
Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated |
Changes proposed in this pull request:
_prevDim
which stores dimensions at time of firingionInfinite
eventscrollTop
conflict, just disable and reenable motion after some timeIonic Version: 3.x
Fixes: #11587